Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove freezegun as a test dependency since it is not used #875

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We list freezegun as a test dependency, but it's not used anywhere. It just winds up generating dependabot PRs.

Solution

Remove the dependency. It was left over from the monorepo but does not apply here.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 19, 2024
@mikealfare mikealfare requested a review from a team as a code owner July 19, 2024 17:31
@cla-bot cla-bot bot added the cla:yes label Jul 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare changed the title Remove freezegun as a test dependency since it's not used Remove freezegun as a test dependency since it is not used Jul 19, 2024
@mikealfare mikealfare enabled auto-merge (squash) July 19, 2024 17:34
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you get tests to pass

@mikealfare mikealfare merged commit f261d17 into main Jul 23, 2024
28 checks passed
@mikealfare mikealfare deleted the remove-freezegun-test-dep branch July 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants