Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.5.latest] Move to pre-commit only (#777) #859

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Backport 1.5.latest] Move to pre-commit only (#777) #859

merged 1 commit into from
Jul 17, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

There is a version conflict between dev dependencies and build dependencies for Python > 3.9. Despite this being an unsupported version, this will prevent us from merging anything urgent.

Solution

Backport #777

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare
Move to pre-commit only (#777)
9efd476 
* moving linting config into pre-commit-config
* remove explicit call to mypy
* run linting
* fix enum reference
@mikealfare mikealfare self-assigned this Jul 17, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 17, 2024
@VersusFacit VersusFacit self-requested a review July 17, 2024 21:38
@mikealfare mikealfare merged commit 8823152 into 1.5.latest Jul 17, 2024
38 of 40 checks passed
@mikealfare mikealfare deleted the backport/1.5.latest/dev-dep-version-conflict branch July 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @VersusFacit