Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal release naming and arguments #849

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Update internal release naming and arguments #849

merged 3 commits into from
Jun 21, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Jun 19, 2024 •
edited
Loading

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner June 19, 2024 18:36
@cla-bot cla-bot bot added the cla:yes label Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Jun 19, 2024
mikealfare
mikealfare reviewed Jun 20, 2024
View reviewed changes
.github/workflows/release-internal.yml
call-release-workflow:
needs: [unit-tests, integration-tests, integration-tests-flaky]
name: "Create cloud release"
uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@main"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this workflow runs the integration tests, I think it will fail due to the AWS CLI not being setup.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that we're skipping tests below

@mikealfare mikealfare merged commit 3885699 into main Jun 21, 2024
27 checks passed
@mikealfare mikealfare deleted the updateIRWorkflow branch June 21, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @mikealfare