Pin to 2.1.1 and below to fix the cursor error. #844
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
| @@ -64,7 +64,7 @@ def _plugin_version_trim() -> str: | |||
| f"dbt-postgres~={_plugin_version_trim()}", | |||
| # dbt-redshift depends deeply on this package. it does not follow SemVer, therefore there have been breaking changes in previous patch releases | |||
| # Pin to the patch or minor version, and bump in each new minor version of dbt-redshift. | |||
| "redshift-connector<2.0.918,>=2.0.913,!=2.0.914", | |||
| "redshift-connector<2.1.1,>=2.0.913,!=2.0.914", | |||
There was a problem hiding this comment.
Is there a reason to pin less than a specific patch? I know we've been broken in the past, but if this package is indicating that they're going to start using minors, then I would think we pin to 2.1, not 2.1.x.
There was a problem hiding this comment.
we should follow up with them and see if that's actually what's happening here or if they just decided to do a minor version bump
Problem
We want to fold in the fix from this patched issue on redshift connector.
Solution
Up the pin. soft pinned since either patch version in
2.1should workChecklist