Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove group_federation for serverless #836

Merged
merged 16 commits into from
Jun 13, 2024
Merged

Remove group_federation for serverless #836

merged 16 commits into from
Jun 13, 2024

Conversation

Fleid
Copy link
Contributor

@Fleid Fleid commented May 31, 2024 •
edited
Loading

See this convo: https://dbt-labs.slack.com/archives/C04FN4114AD/p1717037952388479

Resolves #835 835

This has no test :/
But I confirmed the connection now hits redshift instead or returning:

  >Database Error
  'RedshiftServerless' object has no attribute 'get_cluster_credentials_with_iam'

@Fleid Fleid requested a review from a team as a code owner May 31, 2024 18:37
@cla-bot cla-bot bot added the cla:yes label May 31, 2024
mikealfare
mikealfare previously approved these changes Jun 11, 2024
View reviewed changes
@mikealfare mikealfare dismissed their stale review June 11, 2024 19:09

While we can't run integration tests currently, we can (and I think need to) update unit tests.

@mikealfare
Copy link
Contributor

mikealfare commented Jun 11, 2024 •
edited
Loading

This unit test should be used as a template for creating a new unit test TestIAMRoleMethodServerless, similar to how we have TestIAMUserMethod and TestIAMUserMethodServerless.

mikealfare
mikealfare approved these changes Jun 12, 2024
View reviewed changes
dbt/adapters/redshift/connections.py Show resolved Hide resolved
.changes/unreleased/Fixes-20240531-113620.yaml Outdated Show resolved Hide resolved
@Fleid Fleid closed this Jun 12, 2024
@Fleid Fleid reopened this Jun 12, 2024
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) June 13, 2024 02:58
@colin-rogers-dbt colin-rogers-dbt merged commit 885db2d into main Jun 13, 2024
27 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the serverless_group_federation branch June 13, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] dbt-redshift should not use group_federation=true when connecting with Serverless.
3 participants
@Fleid @mikealfare @colin-rogers-dbt