Add new defer_relation argument to mock_model
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McKnight-42
approved these changes
Jul 6, 2023
|
@mikealfare so it wasn't a actual mashumuro failure good to know great catch |
mikealfare
changed the base branch from
main
to
bug/redshift-connector/2_0_912-connection-error
mikealfare
changed the base branch from
bug/redshift-connector/2_0_912-connection-error
to
main
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
* add new `defer_relation` argument to `mock_model` * changie * exclude redshift-connector==2.0.912 (dbt-labs#519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
defer_relationis an optional argument that was added toModelNodeas part of thedbt clonework. Despite it being optional,MagicMockwas trying to mock it up, which failed validation tests onPath. This new argument was added to the mock parameters with a value ofNoneto avoid creating it.Checklist
changie newto create a changelog entry