Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding timestamp to cart #332

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

samejima-san
Copy link
Contributor

I added the timestamp to the query on the Entry.js

@netlify
Copy link

netlify bot commented Aug 11, 2023

👷 Deploy request for useshoppingcart pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3f039b4

@dayhaysoos
Copy link
Owner

Oh sick! I'm gonna merge this, but before I make a release I'd like to write a test and add this value to my types.

I also want to try to fix another issue. Thank you for this tho! 🙏🏼

@samejima-san
Copy link
Contributor Author

Oh sick! I'm gonna merge this, but before I make a release I'd like to write a test and add this value to my types.

I also want to try to fix another issue. Thank you for this tho! 🙏🏼

please let me know of other issues, i'll keep an eye out for them!

@dayhaysoos
Copy link
Owner

If you're curious, I've been dealing with weird SSG stuff since React 18:

#319

I haven't had time to mess with the new framework upgrades and stuff but I think this is a big problem. Gonna try to figure something out this weekend

@samejima-san
Copy link
Contributor Author

samejima-san commented Aug 13, 2023

If you're curious, I've been dealing with weird SSG stuff since React 18:

#319

I haven't had time to mess with the new framework upgrades and stuff but I think this is a big problem. Gonna try to figure something out this weekend

wont be able to check for that issue until i get my windows machine back, i think the module 'sharp' doesnt support ARM architecture just yet

@dayhaysoos dayhaysoos merged commit 0df8624 into dayhaysoos:master Sep 18, 2023
@dayhaysoos
Copy link
Owner

Gonna try to add this in the next release, thank you!

@samejima-san samejima-san deleted the adding-timestamp-cart branch September 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants