Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of variables related to time to float #281

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Change type of variables related to time to float #281

wants to merge 7 commits into from
+20 −20

Conversation

ghsdh3409
Copy link

@ghsdh3409 ghsdh3409 commented Mar 31, 2018 •
edited
Loading

Summary

  • Before this change, seekTo and currentTime worked with integer second.
  • It supports FLOAT SECONDS in the seekTo and currentTime.
  • I checked that seekTo and currentTime works on both iOS and Android.

Test/Review Plan

  • Code Review
  • Please test it works on the SAMPLE PROJECT.

Comment

  • Sorry for unclean commits. Please merge this by SQUASH MERGE.

@ghsdh3409
Copy link
Author

@ohtangza

ohtangza
ohtangza approved these changes Mar 31, 2018
View reviewed changes
Copy link

@ohtangza ohtangza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes the type of seconds from integer to float by changing its data type. This only changes the type, not the value, so complies with backward-compatibility.

@webdevbyjoss
Copy link

webdevbyjoss commented Jan 8, 2019 •
edited
Loading

@ohtangza @ghsdh3409 hey guys, any chance we could get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohtangza ohtangza ohtangza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change type of variables related to time to float
3 participants
@ghsdh3409 @webdevbyjoss @ohtangza