[DO NOT MERGE] Aggregation variables first draft #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the authors list from version v1.10. I don't know affiliations or ORCIDs, but it's better anyways each one to add yours.
As discussed in the meeting today.
My branch was behind with the official main creating some confusion with @larsbarring's PR. I rebased my branch, and I'm adding here his changes.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: David Hassell <[email protected]>
Copied from cf-conventions website.
Copied from CF-Conventions website.
@ethanrd and @JonathanGregory , I just noticed that @kevin-obrien is missing on the contributors' list (https://github.com/cf-convention/cf-convention.github.io/blob/main/conventions_contributors.md) @kevin-obrien, could you double check your affiliation and orcid here, please?
It looks like I was using the wrong label according to: https://spdx.org/licenses/CC0-1.0.html
This reverts commit 7a45844.
As requested by @JonathanGregory.
As requested by @ethanrd
Co-authored-by: Ethan Davis <[email protected]>
@taylor13 , could you verify if it, please?
@japamment, could you double check it, please?
As requested by @japamment.
Co-authored-by: Martin Raspaud <[email protected]>
davidhassell
changed the title
sadielbartholomew
approved these changes
May 10, 2024
There was a problem hiding this comment.
Overall I am very happy with this. Thanks for addressing my previous feedback. Ive raised some final minor comments but nothing substantial save for perhaps the need to clarify whether packing is forbidden or just advised against (see in-line comment). Please go ahead and raise formally to the CF Conventions when you've considered those.
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Initializing a descriptor for Zenodo's DOI
clarify the recommendation to use the convention of 4.3.3 for parametric vertical coordinates
…ension, attribute and group names is a recommendation, not a requirement
Clarify that the character set given in section 2.3 for variable, dimension, attribute and group names is a recommendation, not a requirement
Fix typo 'principal' -> 'principle' in ch02
|
Comments on wording/syntax:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #XXX for discussion of these changes.
Release checklist
cf-conventions.adoc?cf-conventions.adocup to date? Versioning inspired by SemVer.history.adocup to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then
masteralways is a draft for the next version.