Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clearing an empty hint console.warn #270

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove clearing an empty hint console.warn #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/content/hints/HintClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,10 +648,7 @@ export class HintClass implements Hint {

// Checking this.string is safer than check in this.inner.textContent as the
// latter could be removed by a page script
if (!this.string) {
console.warn("Releasing an empty hint");
return;
}
if (!this.string) return;

clearHintedWrapper(this.string);

Expand Down
Loading