Prevent and fix restricted imports between src/background, src/conten…

…t and src/common (#313)

package.json

@@ -126,7 +126,70 @@
 			"@typescript-eslint/ban-types": "off",
 			"no-redeclare": "off",
 			"@typescript-eslint/no-redeclare": "off"
-		}
+		},
+		"overrides": [
+			{
+				"files": [
+					"src/background/**"
+				],
+				"rules": {
+					"no-restricted-imports": [
+						"error",
+						{
+							"patterns": [
+								{
+									"group": [
+										"**/content/**"
+									],
+									"message": "Modules within /src/background can't import from /src/content"
+								}
+							]
+						}
+					]
+				}
+			},
+			{
+				"files": [
+					"src/content/**"
+				],
+				"rules": {
+					"no-restricted-imports": [
+						"error",
+						{
+							"patterns": [
+								{
+									"group": [
+										"**/background/**"
+									],
+									"message": "Modules within /src/content can't import from /src/background"
+								}
+							]
+						}
+					]
+				}
+			},
+			{
+				"files": [
+					"src/common/**"
+				],
+				"rules": {
+					"no-restricted-imports": [
+						"error",
+						{
+							"patterns": [
+								{
+									"group": [
+										"**/background/**",
+										"**/content/**"
+									],
+									"message": "Modules within /src/content can't import from /src/background or /src/content"
+								}
+							]
+						}
+					]
+				}
+			}
+		]
 	},
 	"prettier": {
 		"trailingComma": "es5",

src/background/hints/hintsAllocator.ts

@@ -3,7 +3,7 @@ import browser from "webextension-polyfill";
 import { getKeysToExclude } from "../../common/getKeysToExclude";
 import { retrieve, store } from "../../common/storage";
 import { HintsStack } from "../../typings/StorageSchema";
-import { letterHints, numberHints } from "../utils/allHints";
+import { letterHints, numberHints } from "../../common/allHints";
 import { navigationOccurred } from "./preloadTabs";
 
 async function getEmptyStack(tabId: number): Promise<HintsStack> {

src/background/misc/tabMarkers.ts

@@ -2,7 +2,7 @@ import browser from "webextension-polyfill";
 import { Mutex } from "async-mutex";
 import { retrieve, store } from "../../common/storage";
 import { TabMarkers } from "../../typings/StorageSchema";
-import { letterHints } from "../utils/allHints";
+import { letterHints } from "../../common/allHints";
 import { sendRequestToContent } from "../messaging/sendRequestToContent";
 
 const mutex = new Mutex();

src/common/defaultStorage.ts

@@ -1,5 +1,5 @@
-import { letterHints } from "../background/utils/allHints";
 import { StorageSchema } from "../typings/StorageSchema";
+import { letterHints } from "./allHints";
 import { defaultSettings } from "./settings";
 
 export const defaultStorage: StorageSchema = {

src/common/transformSettings.ts

@@ -1,7 +1,7 @@
 import { z } from "zod";
-import { isValidSelector } from "../content/utils/selectorUtils";
-import { isValidRegExp } from "../content/utils/textUtils";
 import { CustomSelector, StorageSchema } from "../typings/StorageSchema";
+import { isValidSelector } from "./selectorUtils";
+import { isValidRegExp } from "./textUtils";
 
 type CustomsSelectorsLegacyEntry = [
 	string,

src/content/hints/computeCustomSelectors.ts

@@ -5,7 +5,7 @@ import {
 	getSpecificityValue,
 	isValidSelector,
 	selectorToArray,
-} from "../utils/selectorUtils";
+} from "../../common/selectorUtils";
 import { SelectorAlternative } from "../../typings/SelectorAlternative";
 
 function getChildNumber(target: Element) {

src/settings/CustomHintsSetting.tsx

@@ -2,8 +2,8 @@ import { faBan, faPlus, faTrash } from "@fortawesome/free-solid-svg-icons";
 import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
 import { CustomSelector } from "../typings/StorageSchema";
 import "./CustomHintsSetting.css";
-import { isValidSelector } from "../content/utils/selectorUtils";
-import { isValidRegExp } from "../content/utils/textUtils";
+import { isValidSelector } from "../common/selectorUtils";
+import { isValidRegExp } from "../common/textUtils";
 
 type CustomHintsSettingProp = {
 	value: CustomSelector[];