Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unavailability to free memory in cache #345

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
5 changes: 4 additions & 1 deletion src/module_threads.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,14 @@ int snap_cow_thread(void *data)
cow_free_members(dev->sd_cow);
}

#if defined USE_BDOPS_SUBMIT_BIO && defined HAVE_FOPS_FALLOCATE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright change, otherwise a logical catch :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated copyright

//not having it for .deb causes infinite loop and failure, having this for rpms causes objdump caused by not being able to save cached data during unmounting
int should_stop=kthread_should_stop();
if(should_stop){
LOG_DEBUG("stopping snap thread in if");
LOG_DEBUG("stopping snap thread in conditional");
break;
}
#endif

if (bio_queue_empty(bq))
continue;
Expand Down