Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload.ts #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ardinusawan
Copy link

Make config array as per constructor

The constructor

    constructor(...[configuration]: __CheckOptionalClientConfig<S3ClientConfig>);
    /**

Make config array as per constructor
@anuveyatsu anuveyatsu requested a review from demenech July 29, 2024 06:28
@demenech
Copy link
Member

hi @ardinusawan

Sorry for the delay and thank you very much for this contribution.

Did this raise a warning or an exception on your editor?

I'm trying to understand this. On my LSP configuration, it doesn't complain about having an array there, but looking at the source code it doesn't seem right: https://github.com/aws/aws-sdk-js-v3/blob/de8d4a6bcffdb94f0d3b23f65fdb203136498a31/clients/client-s3/src/S3Client.ts#L776-L777

I'm not sure, tho, why configuration is in an array that is spread.

CC: @anuveyatsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants