-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics][l]: #238 Add support for plausible, simpleanalytics, Google, PostHog analytics #614
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mohamedsalem401 did you follow pliny here? Could we even directly reuse pliny via importing their modules? And could you reference the issue this came from in the PR please 🙏 |
@rufuspollock Yes I did follow Pliny. |
@mohamedsalem401 should these changes be upstream in the core repo i.e. https://github.com/datopian/portaljs/tree/main/packages/core/src? (I'm not certain but wanted to check). Generally, we want stuff in a core library and then we just import the parts we want in the template (in a perfect world we only import something if we use it). cf how pliny approaches this ... |
@rufus, as per your suggestion, I managed to find the npm package for Pliny: https://www.npmjs.com/package/pliny. It doesn't have any documentation, I tried to pull the components of the npm package. It didn't workout ( without even throwing any error ) 1- I will see if I should push those changes to https://github.com/datopian/portaljs/tree/main/packages/core/src |
I moved the components to |
For #238
config.mjs