Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keepAlive to false #99

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Set keepAlive to false #99

merged 1 commit into from
Apr 24, 2024

Conversation

rick-a-lane-ii
Copy link
Collaborator

Description

The use of Node was upgraded from 16 to 20, per the rapidly approaching deprecation of Node 16 in GitHub Actions.

Noting that GitHub Actions does not support Node 18.

The use of Node 20 (by virtue of Node 19) has changed keepAlive to be true by default.

Starting with this release, Node.js sets keepAlive to true by default. This means that any outgoing HTTP(s) connection will automatically use HTTP 1.1 Keep-Alive.

This has had an impact on a great number of GitHub Actions. Reference setup-ruby for one such issue.

Additionally, the @actions/http-client (which we are using) had to be updated to support the changes. I've updated all of our dependencies in #98, including @actions/http-client to pick up the necessary changes.

This fix includes the final necessary step to avoid the unnecessary delays.

@rick-a-lane-ii rick-a-lane-ii requested review from thallgren and a team April 24, 2024 10:17
@rick-a-lane-ii rick-a-lane-ii merged commit 97a247b into main Apr 24, 2024
14 checks passed
@rick-a-lane-ii rick-a-lane-ii deleted the integration/set-keep-alive branch April 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants