Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add sassOptions.outputStyle to expanded in rspack.config.js #65

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: add sassOptions.outputStyle to expanded in rspack.config.js #65

merged 2 commits into from
Apr 3, 2024

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Mar 28, 2024

Coming from https://github.com/datavisyn/reprovisyn/issues/1665

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added release: patch PR merge results in a new patch version type: bug Something isn't working labels Mar 28, 2024
@thinkh thinkh requested a review from puehringer March 28, 2024 12:04
@thinkh thinkh self-assigned this Mar 28, 2024
@thinkh thinkh requested a review from a team as a code owner March 28, 2024 12:04
@dvmoritzschoefl
Copy link
Contributor

Tested it in Aevidence and had no problem

@puehringer puehringer merged commit 2d6417b into develop Apr 3, 2024
1 check passed
@puehringer puehringer deleted the thinkh/fix-scrambled-fontawesome-icons branch April 3, 2024 08:11
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 24, 2024
Merged
puehringer added a commit that referenced this pull request Apr 24, 2024
@puehringer
Release 8.0.3 (#70)
8c1563e 
## What's changed

* fix: add sassOptions.outputStyle to expanded in rspack.config.js
(#65)
* deps: remove @storybook/addon-mdx-gfm as it breaks the build
(#68)
* feat: allow setting devtool=false
(#69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvmoritzschoefl dvmoritzschoefl dvmoritzschoefl approved these changes

@puehringer puehringer Awaiting requested review from puehringer

Assignees

@thinkh thinkh

@dvmoritzschoefl dvmoritzschoefl

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkh @dvmoritzschoefl @puehringer