visTree: Make .generateYColor robust towards NaN and degenerate trees #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make color ramp generation robust against two degenerate cases:
object$frame$yval
.object$frame$yval
which might result in yval range in a tree being 0 which results in division by 0 in this line.Both cases can occur in trees which were refit to new data. That is,
yval
values and node counts are recomputed on new data but preserving the tree structure. Unfortunately there is no built in functionality for such a "refit" in rpart, so I have my own custom code for that. Thus cannot provide a simple repro. But hopefully the PR is simple enough not to require that.An example of such a tree: