Bun Support #416
Open
Bun Support #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing how we connect to the net client so runtimes like bun will work (tested this on 1.0.6)
In bun, for some reason when concating buffers if the length is set to undefined, bun returns a empty buffer. This fixes that (still works in node, tested on bun v1.06 and node v16.20.2+)
|
I've also already signed the datastax CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm using bun for one of my projects. I'm also using cassandra-driver. These are a few issues which cause the driver to not work with bun. I've gone ahead and fixed them.
I tested this on bun version 1.0.6, With that I also tested with node v16.20.2+