Add collections e2e tests (#1846)

datalens-tech · Dec 4, 2024 · d816ba8 · d816ba8
1 parent d118094
commit d816ba8
Show file tree

Hide file tree

Showing 22 changed files with 272 additions and 40 deletions.
diff --git a/scripts/e2e/us-dump.sh b/scripts/e2e/us-dump.sh
@@ -40,8 +40,9 @@ if [ $CONNECTION_CHECK_RESULT_STATUS_CODE -ne 0 ]; then
     exit 1
 fi
 
-DUMP_CMD="pg_dump --dbname=$US_CONNECTION --column-inserts -a -t workbooks -t entries -t revisions -t links"
-docker exec -it $US_CONTAINER_ID /bin/sh -c "$DUMP_CMD" | grep -Ev "^(--|SET|SELECT pg_catalog.set_config)" >$DUMP_TMP
+DUMP_CMD="pg_dump --dbname=$US_CONNECTION --disable-triggers --column-inserts -a -t collections -t workbooks -t entries -t revisions -t links"
+docker exec -it $US_CONTAINER_ID /bin/sh -c "$DUMP_CMD" |
+tee >(grep -Ev "^(--|SET|SELECT pg_catalog.set_config|pg_dump:)" >$DUMP_TMP) | grep "pg_dump:"
 DUMP_RESULT_STATUS_CODE=$?
 
 if [ $DUMP_RESULT_STATUS_CODE -ne 0 ]; then

diff --git a/src/shared/constants/qa/collections.ts b/src/shared/constants/qa/collections.ts
@@ -0,0 +1,6 @@
+export const enum CollectionContentTableQa {
+    Table = 'coll-content-table',
+    CollectionLinkRow = 'coll-content-table-coll-link-row',
+    WorkbookLinkRow = 'coll-content-table-workbook-link-row',
+    CollectionTitleCell = 'coll-content-table-coll-title-cell',
+}
diff --git a/src/shared/constants/qa/index.ts b/src/shared/constants/qa/index.ts
@@ -1,14 +1,15 @@
+export {VisualizationsQa} from './visualization';
+export * from './chart';
+export * from './collections';
 export * from './components';
 export * from './connections';
-export * from './chart';
-export * from './editor';
-export * from './datasets';
+export * from './control';
 export * from './dash';
+export * from './datasets';
 export * from './dl-navigation';
-export * from './wizard';
-export * from './control';
-export * from './ql';
+export * from './editor';
 export * from './field-editor';
-export {VisualizationsQa} from './visualization';
-export * from './uikit';
+export * from './ql';
 export * from './settings';
+export * from './uikit';
+export * from './wizard';
diff --git a/src/shared/constants/qa/workbooks.ts b/src/shared/constants/qa/workbooks.ts
@@ -1,5 +1,6 @@
-export enum WorkbookPage {
+export enum WorkbookPageQa {
     ListItem = 'workbook-page-list-item',
     MenuDropDownBtn = 'workbook-page-list-item-menu-btn',
     MenuItemDuplicate = 'workbook-page-list-item-menu-item-duplicate',
+    Filters = 'workbook-page-filters',
 }
diff --git a/src/ui/units/collections/components/CollectionContentTable/CollectionContentTable.tsx b/src/ui/units/collections/components/CollectionContentTable/CollectionContentTable.tsx
@@ -6,7 +6,7 @@ import {Checkbox, DropdownMenu, Tooltip} from '@gravity-ui/uikit';
 import block from 'bem-cn-lite';
 import {I18n} from 'i18n';
 import {useSelector} from 'react-redux';
-import {DEFAULT_DATE_FORMAT} from 'shared/constants';
+import {CollectionContentTableQa, DEFAULT_DATE_FORMAT} from 'shared/constants';
 import {DL} from 'ui/constants/common';
 import {selectDateTimeFormat} from 'ui/store/selectors/user';
 
@@ -74,7 +74,7 @@ export const CollectionContentTable = React.memo<Props>(
 
         if (DL.IS_MOBILE) {
             return (
-                <div className={b({mobile: true})}>
+                <div className={b({mobile: true})} data-qa={CollectionContentTableQa.Table}>
                     <AnimateBlock>
                         <div className={b('table')}>
                             <div className={b('content')}>
@@ -107,7 +107,7 @@ export const CollectionContentTable = React.memo<Props>(
         }
 
         return (
-            <div className={b()}>
+            <div className={b()} data-qa={CollectionContentTableQa.Table}>
                 <AnimateBlock>
                     <div className={b('table')}>
                         <div className={b('header')}>

diff --git a/...units/collections/components/CollectionContentTable/TableComponents/CollectionLinkRow.tsx b/...units/collections/components/CollectionContentTable/TableComponents/CollectionLinkRow.tsx
@@ -3,6 +3,7 @@ import React from 'react';
 import block from 'bem-cn-lite';
 import {batch, useDispatch, useSelector} from 'react-redux';
 import {Link} from 'react-router-dom';
+import {CollectionContentTableQa} from 'shared';
 import type {CollectionWithPermissions, WorkbookWithPermissions} from 'shared/schema/types';
 import {DL} from 'ui/constants/common';
 import {selectCollectionBreadcrumbs} from 'ui/units/collections-navigation/store/selectors';
@@ -24,17 +25,24 @@ export const CollectionLinkRow: React.FC<CollectionLinkRowProps> = ({children, i
     const dispatch = useDispatch();
     const breadcrumbs = useSelector(selectCollectionBreadcrumbs) ?? [];
 
+    const isWorkbookItem = 'workbookId' in item;
+
     return (
         <Link
+            data-qa={
+                isWorkbookItem
+                    ? CollectionContentTableQa.WorkbookLinkRow
+                    : CollectionContentTableQa.CollectionLinkRow
+            }
             to={
-                'workbookId' in item
+                isWorkbookItem
                     ? `${WORKBOOKS_PATH}/${item.workbookId}`
                     : `${COLLECTIONS_PATH}/${item.collectionId}`
             }
             className={b('content-row')}
             onClick={(e) => {
                 if (!e.metaKey && !e.ctrlKey) {
-                    if ('workbookId' in item) {
+                    if (isWorkbookItem) {
                         dispatch(setWorkbook(item));
                     } else {
                         batch(() => {

diff --git a/...its/collections/components/CollectionContentTable/TableComponents/CollectionTitleCell.tsx b/...its/collections/components/CollectionContentTable/TableComponents/CollectionTitleCell.tsx
@@ -1,6 +1,7 @@
 import React from 'react';
 
 import block from 'bem-cn-lite';
+import {CollectionContentTableQa} from 'shared';
 import {CollectionIcon} from 'ui/components/CollectionIcon/CollectionIcon';
 import {WorkbookIcon} from 'ui/components/WorkbookIcon/WorkbookIcon';
 import {DL} from 'ui/constants/common';
@@ -25,7 +26,11 @@ export const CollectionTitleCell = ({
     const collectionSize = DL.IS_MOBILE ? 28 : undefined;
 
     return (
-        <div className={b('content-cell', {title: true})} key={collectionId}>
+        <div
+            className={b('content-cell', {title: true})}
+            key={collectionId}
+            data-qa={CollectionContentTableQa.CollectionTitleCell}
+        >
             <div className={b('title-col')}>
                 <div>
                     {isWorkbook ? (

diff --git a/src/ui/units/workbooks/components/EntryActions/EntryActions.tsx b/src/ui/units/workbooks/components/EntryActions/EntryActions.tsx
@@ -6,7 +6,7 @@ import {DropdownMenu} from '@gravity-ui/uikit';
 import {I18n} from 'i18n';
 import {Feature} from 'shared';
 import type {ConnectorType} from 'shared/constants/connections';
-import {WorkbookPage} from 'shared/constants/qa/workbooks';
+import {WorkbookPageQa} from 'shared/constants/qa/workbooks';
 import type {WorkbookWithPermissions} from 'shared/schema/us/types';
 import {EntryScope} from 'shared/types/common';
 import {S3_BASED_CONNECTORS} from 'ui/constants';
@@ -58,7 +58,7 @@ export const EntryActions = ({
                   {
                       action: onDuplicateEntry,
                       text: <DropdownAction icon={Copy} text={i18n('action_duplicate')} />,
-                      qa: WorkbookPage.MenuItemDuplicate,
+                      qa: WorkbookPageQa.MenuItemDuplicate,
                   },
               ]
             : []),
@@ -100,7 +100,7 @@ export const EntryActions = ({
         <DropdownMenu
             size="m"
             items={items}
-            defaultSwitcherProps={{qa: WorkbookPage.MenuDropDownBtn}}
+            defaultSwitcherProps={{qa: WorkbookPageQa.MenuDropDownBtn}}
         />
     );
 };
diff --git a/src/ui/units/workbooks/components/Table/WorkbookEntriesTable/Row/Row.tsx b/src/ui/units/workbooks/components/Table/WorkbookEntriesTable/Row/Row.tsx
@@ -9,7 +9,7 @@ import {I18n} from 'i18n';
 import {useDispatch} from 'react-redux';
 import {Link} from 'react-router-dom';
 import {DEFAULT_DATE_FORMAT} from 'shared';
-import {WorkbookPage} from 'shared/constants/qa/workbooks';
+import {WorkbookPageQa} from 'shared/constants/qa/workbooks';
 import type {WorkbookWithPermissions} from 'shared/schema/us/types/workbooks';
 import {registry} from 'ui/registry/index';
 import type {AppDispatch} from 'ui/store';
@@ -81,7 +81,7 @@ const Row: React.FC<RowProps> = ({
                 to={url}
                 className={b({mobile: true})}
                 style={mobileRowStyle}
-                data-qa={WorkbookPage.ListItem}
+                data-qa={WorkbookPageQa.ListItem}
             >
                 <div className={b('content-cell', {title: true})} data-qa={item.entryId}>
                     <div className={b('title-col')}>
@@ -101,7 +101,7 @@ const Row: React.FC<RowProps> = ({
     }
 
     return (
-        <Link to={url} className={b()} style={defaultRowStyle} data-qa={WorkbookPage.ListItem}>
+        <Link to={url} className={b()} style={defaultRowStyle} data-qa={WorkbookPageQa.ListItem}>
             <div className={b('content-cell', {title: true})} data-qa={item.entryId}>
                 <div className={b('title-col', {'is-mobile': DL.IS_MOBILE})}>
                     <EntryIcon entry={item} width={24} height={24} />

diff --git a/src/ui/units/workbooks/components/WorkbookFilters/WorkbookFilters.tsx b/src/ui/units/workbooks/components/WorkbookFilters/WorkbookFilters.tsx
@@ -4,6 +4,7 @@ import {Select} from '@gravity-ui/uikit';
 import block from 'bem-cn-lite';
 import {DebouncedInput} from 'components/DebouncedInput/DebouncedInput';
 import {I18n} from 'i18n';
+import {WorkbookPageQa} from 'shared/constants/qa/workbooks';
 import type {OrderDirection, OrderWorkbookEntriesField} from 'shared/schema/us/types/sort';
 
 import type {WorkbookEntriesFilters} from '../../types';
@@ -94,7 +95,7 @@ export const WorkbookFilters = ({className, filters, onChange}: Props) => {
 
     return (
         <div className={b(null, className)}>
-            <div className={b('controls')}>
+            <div className={b('controls')} data-qa={WorkbookPageQa.Filters}>
                 <DebouncedInput
                     className={b('filter-string')}
                     value={filterString}

diff --git a/tests/constants/constants.ts b/tests/constants/constants.ts
@@ -5,3 +5,11 @@ export const WorkbookIds = {
 export const WorkbooksUrls = {
     E2EWorkbook: `/workbooks/${WorkbookIds.E2EWorkbook}`,
 };
+
+export const CollectionIds = {
+    E2ECollection: 'm45slvqc2k9q9',
+};
+
+export const CollectionsUrls = {
+    E2ECollection: `/collections/${CollectionIds.E2ECollection}`,
+};
diff --git a/tests/data/us-e2e-data b/tests/data/us-e2e-data
diff --git a/tests/opensource-suites/collections/OpenCollectionsPage.test.tsx b/tests/opensource-suites/collections/OpenCollectionsPage.test.tsx
diff --git a/tests/opensource-suites/collections/contentTableItemsLinks.test.ts b/tests/opensource-suites/collections/contentTableItemsLinks.test.ts
@@ -0,0 +1,35 @@
+import {openTestPage} from '../../utils';
+import datalensTest from '../../utils/playwright/globalTestDefinition';
+import {CollectionsPagePO} from '../../page-objects/collections';
+import {Workbook} from '../../page-objects/workbook/Workbook';
+import {WorkbooksUrls, CollectionsUrls} from '../../constants/constants';
+
+datalensTest.describe('Collections page', () => {
+    datalensTest.describe('Content table', () => {
+        datalensTest.beforeEach(async ({page}) => {
+            await openTestPage(page, `/collections`);
+        });
+
+        datalensTest('Workbook row link leads to workbook page', async ({page}) => {
+            const {contentTable} = new CollectionsPagePO({page});
+
+            await contentTable.clickWorkbookRowLink();
+
+            await page.waitForURL(WorkbooksUrls.E2EWorkbook);
+
+            const {filters} = new Workbook(page);
+
+            await filters.waitForVisible();
+        });
+
+        datalensTest('Collection row link leads to collection page', async ({page}) => {
+            const {contentTable, emptyState} = new CollectionsPagePO({page});
+
+            await contentTable.clickCollectionRowLink();
+
+            await page.waitForURL(CollectionsUrls.E2ECollection);
+
+            await emptyState.waitForVisible();
+        });
+    });
+});
diff --git a/tests/page-objects/collections/CollectionsPage.ts b/tests/page-objects/collections/CollectionsPage.ts
@@ -0,0 +1,28 @@
+import {BasePage} from '../BasePage';
+import type {BasePageProps} from '../BasePage';
+import {ContentTablePO} from './ContentTable';
+import {EmptyStatePO} from './EmptyState';
+
+type CollectionsPageProps = BasePageProps;
+
+export class CollectionsPagePO extends BasePage {
+    private readonly root = '.dl-collections-navigation-layout';
+
+    constructor({page}: CollectionsPageProps) {
+        super({page});
+    }
+
+    get emptyState() {
+        return new EmptyStatePO({
+            page: this.page,
+            parent: this.root,
+        });
+    }
+
+    get contentTable() {
+        return new ContentTablePO({
+            page: this.page,
+            parent: this.root,
+        });
+    }
+}
diff --git a/tests/page-objects/collections/ContentTable.ts b/tests/page-objects/collections/ContentTable.ts
@@ -0,0 +1,50 @@
+import {Page} from '@playwright/test';
+import {CollectionContentTableQa} from '../../../src/shared';
+import {slct} from '../../utils';
+import {ElementPO} from '../common/abstract/ElementPO';
+import {ContentTableRowPO} from './ContentTableRow';
+
+type ContentTableProps = {
+    page: Page;
+    parent: string;
+};
+
+export class ContentTablePO extends ElementPO {
+    constructor({page, parent}: ContentTableProps) {
+        super({
+            page,
+            selectors: {
+                root: slct(CollectionContentTableQa.Table),
+                parent,
+            },
+        });
+    }
+
+    get collectionRow() {
+        return new ContentTableRowPO({
+            page: this.page,
+            selectors: {
+                parent: this.getSelector(),
+                root: slct(CollectionContentTableQa.CollectionLinkRow),
+            },
+        });
+    }
+
+    get workbookRow() {
+        return new ContentTableRowPO({
+            page: this.page,
+            selectors: {
+                parent: this.getSelector(),
+                root: slct(CollectionContentTableQa.WorkbookLinkRow),
+            },
+        });
+    }
+
+    async clickCollectionRowLink() {
+        await this.collectionRow.clickRowLink();
+    }
+
+    async clickWorkbookRowLink() {
+        await this.workbookRow.clickRowLink();
+    }
+}
diff --git a/tests/page-objects/collections/ContentTableRow.ts b/tests/page-objects/collections/ContentTableRow.ts
@@ -0,0 +1,26 @@
+import {CollectionContentTableQa} from '../../../src/shared';
+import {ElementPO} from '../common/abstract/ElementPO';
+import type {ElementPOProps} from '../common/abstract/types';
+import {slct} from '../../utils';
+
+type ContentTableRowProps = ElementPOProps;
+
+export class ContentTableRowPO extends ElementPO {
+    constructor({page, selectors}: ContentTableRowProps) {
+        super({page, selectors});
+    }
+
+    get rowTitleCell() {
+        return new ElementPO({
+            page: this.page,
+            selectors: {
+                parent: this.getSelector(),
+                root: slct(CollectionContentTableQa.CollectionTitleCell),
+            },
+        });
+    }
+
+    async clickRowLink() {
+        await this.rowTitleCell.click();
+    }
+}
diff --git a/tests/page-objects/collections/EmptyState.ts b/tests/page-objects/collections/EmptyState.ts
@@ -0,0 +1,19 @@
+import {Page} from '@playwright/test';
+import {ElementPO} from '../common/abstract/ElementPO';
+
+type EmptyStateProps = {
+    page: Page;
+    parent: string;
+};
+
+export class EmptyStatePO extends ElementPO {
+    constructor({page, parent}: EmptyStateProps) {
+        super({
+            page,
+            selectors: {
+                root: '.dl-collection-content__empty-state',
+                parent,
+            },
+        });
+    }
+}
diff --git a/tests/page-objects/collections/index.ts b/tests/page-objects/collections/index.ts
@@ -0,0 +1 @@
+export {CollectionsPagePO} from './CollectionsPage';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export {CollectionsPagePO} from './CollectionsPage';