Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for DataTable Prime components #884

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 24, 2024

Closes #1012
#794 & #889

Add component test for:

  • SampleTable
  • CollectionTable
  • EquipmentTable
  • StartingMaterialTable

Add e2e test for:

  • startingMaterial (Only for EDITABLE_INVENTORY false, test that the button 'Add a starting material' isn't displayed)

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (ae09e24) to head (f65756c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           
---- 🚨 Try these New Features:

Copy link

cypress bot commented Sep 24, 2024

datalab    Run #2802

Run Properties:  status check passed Passed #2802  •  git commit 02eef1e264 ℹ️: Merge f65756c8d173fecf012188f03d3fdd32341ae43f into ae09e24acc67e9795fe1ee542485...
Project datalab
Branch Review bc/components_test
Run status status check passed Passed #2802
Run duration 07m 34s
Commit git commit 02eef1e264 ℹ️: Merge f65756c8d173fecf012188f03d3fdd32341ae43f into ae09e24acc67e9795fe1ee542485...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes force-pushed the bc/components_test branch 2 times, most recently from fef8c4c to 404af58 Compare October 4, 2024 16:13
@ml-evs ml-evs added this to the v0.5.x milestone Oct 8, 2024
@BenjaminCharmes BenjaminCharmes added testing For issues/PRs that change how the package is tested API For issues/PRs pertaining to the API webapp For issues/PRs pertaining to the web interface labels Oct 8, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this is basically ready to merge from my side, once the tests are passing again. We can then start adding more incrementally

BenjaminCharmes and others added 2 commits November 20, 2024 11:42
Update components test with last updates

Update VUE_APP_EDITABLE_INVENTORY in Cypress

Update starting_materials test to work with EDITABLE_INVENTORY false

Fix date receive from Vuex store in cypress

Fix date receive from Vuex store in cypress

Fix date receive from Vuex store in cypress

Fix startMaterial cypress test
@BenjaminCharmes
Copy link
Contributor Author

I remove the starting_materials e2e test for now because the EDITABLE_INVENTORY is false by default. So we need to decide if we only test the starting_material page when we can't edit the inventory, or if we should test it when it's true (or both?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API For issues/PRs pertaining to the API testing For issues/PRs that change how the package is tested webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for checking whether components are rendered in the table
2 participants