-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for DataTable Prime components #884
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246
|
9dfc4f6
to
50ee1d9
Compare
datalab Run #2802
Run Properties:
|
Project |
datalab
|
Branch Review |
bc/components_test
|
Run status |
Passed #2802
|
Run duration | 07m 34s |
Commit |
02eef1e264 ℹ️: Merge f65756c8d173fecf012188f03d3fdd32341ae43f into ae09e24acc67e9795fe1ee542485...
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
471
|
View all changes introduced in this branch ↗︎ |
5d6bc68
to
fcd512b
Compare
fef8c4c
to
404af58
Compare
0521cec
to
53451c4
Compare
23dfa9e
to
16f8c73
Compare
16f8c73
to
3043fe2
Compare
3043fe2
to
22da19f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think this is basically ready to merge from my side, once the tests are passing again. We can then start adding more incrementally
Update components test with last updates Update VUE_APP_EDITABLE_INVENTORY in Cypress Update starting_materials test to work with EDITABLE_INVENTORY false Fix date receive from Vuex store in cypress Fix date receive from Vuex store in cypress Fix date receive from Vuex store in cypress Fix startMaterial cypress test
20d12dd
to
3cb47ea
Compare
I remove the starting_materials e2e test for now because the EDITABLE_INVENTORY is false by default. So we need to decide if we only test the starting_material page when we can't edit the inventory, or if we should test it when it's true (or both?) |
Closes #1012
#794 & #889
Add component test for:
Add e2e test for: