User select and sharing of sample page with creators #830
+422
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
+ Coverage 68.49% 68.62% +0.12%
==========================================
Files 62 62
Lines 3955 3993 +38
==========================================
+ Hits 2709 2740 +31
- Misses 1246 1253 +7
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/creators-ui
|
| Run status |
|
| Run duration | 07m 31s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
2 times, most recently
from
493b915
to
9aa4708
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
from
6fa9afc
to
259955f
Compare
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
2 times, most recently
from
c0bb29a
to
a055f7a
Compare
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
from
a055f7a
to
6f84324
Compare
jdbocarsly
reviewed
Nov 1, 2024
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
from
6f84324
to
cc83db0
Compare
ml-evs
commented
Nov 6, 2024
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
4 times, most recently
from
2ea51fb
to
e9cae07
Compare
This was referenced Nov 14, 2024
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
from
efb38eb
to
74d3674
Compare
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
2 times, most recently
from
f0c37f6
to
b0a65ff
Compare
- Run Pydantic validation in search-users endpoint - Ensure creator ID is returned by `/items` endpoint within creators object Add specialised route for adding creators to items - Make it so users cannot remove themselves nor the original creator from creators lists
Add contact_email to the API response when searching user to display Gravatar Icon inside the Creators vSelect Filter user that are already been selected to not appear in the vSelect Update creators doesn't trigger the 'Unsaved change' Add toggleable creators to cell type, and try to limit creator display names
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
2 times, most recently
from
7b3dabd
to
047fe7d
Compare
- Make sure creators order is preserved in lookup - Better handle case of item with no creators - Better error messages and handling of edge cases - Better client-side handling of edge cases and invalid inputs in creator selection - Tweak permissions test - Fix typo... - Use data-test-id for better encapsulation of dropdown testing
ml-evs
force-pushed
the
ml-evs/creators-ui
branch
from
047fe7d
to
f7aa49b
Compare
|
This has been deployed on @PeterKraus's deployment for a few weeks now and seems to be working well (pending future enhancements to also apply it to collections). Since all I've done since then is add data-testid's to get the e2e tests working, I'm going to take responsibility and merge this now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a user select and toggleable editable option to the creator list for items.
It should prevent the user from removing themselves, and should potentially prevent the user from removing other people (i.e. append-only share), or some more tortured logic where the "first" creator in the list takes precedence.
This also adds a new API route
PATCH /items/<refcode>/permissionsfor this use case, with some tests.Works similarly to the toggleable collection block, except that API call is made when the editing state is completed, and has a confirmation dialog.
Some outstanding things (for this PR or otherwise):