Use <router-link> for "Home" button on edit page to preserve store
#1018
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/router-link-edit-page
|
| Run status |
|
| Run duration | 07m 07s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
471
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/router-link-edit-page
branch
from
6f44cfc
to
9c570d0
Compare
ml-evs
force-pushed
the
ml-evs/router-link-edit-page
branch
from
9c570d0
to
5a9ee9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will preserve the store when going back and forth betweens samples via the home button.
I think more generally, we can now think of more aggressively caching table data to speed-up load times, i.e., on table load, first just check the store and use that value if its not empty. Potentially an async load could then be triggered in the background (related to #1013 (review)).