fix: report hydrated schemas from flight_info requests #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With flight_info requests the returned schema needs to exactly match the encoded flight data. The FlightDataEncoder will change the schema in order to hydrate dictionaries. This means the schema reported from flight_info requests did not match the encoded data. This change copies the logic from arrow-flight that can transform a schema for hydrated dictionaries. See apache/arrow-rs#6672 where the copied logic may be exposed directly.
hozan23
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With flight_info requests the returned schema needs to exactly match the encoded flight data. The FlightDataEncoder will change the schema in order to hydrate dictionaries. This means the schema reported from flight_info requests did not match the encoded data.
This change copies the logic from arrow-flight that can transform a schema for hydrated dictionaries. See
apache/arrow-rs#6672 where the copied logic may be exposed directly.