Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve Promises in response values before sending #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zagrebelin
Copy link

If response data contains a Promise objects (say, Dataloaders were used), encoding to json these objects will silently fail.

@DayS1eeper
Copy link

It must be fixed inside graphql-core library. Also, batching currently is not working while resolving subscription result. I opened PR to fix this problem graphql-python/graphql-core-legacy#287

@justuswilhelm
Copy link

@DayS1eeper Is the issue in graphql-core or graphql-core-legacy? Which library is DjangoChannelsGraphqlWs using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants