delete instructor handouts

[zkamvar]

This is a followup to #466 in relation to #464 because the lesson build is currently failing with this error during the HTML build phase:

  Error in normalizePath(path, winslash = "/", mustWork = TRUE) : 
    path[1]="/home/runner/work/r-socialsci/r-socialsci/site/built/data-visualisation-handout.md": No such file or directory
  Calls: <Anonymous> ... root_path -> <Anonymous> -> get_start_path -> normalizePath

Details of error

In the workbench transition (see #411 (comment)) for this lesson, the default spot for any of the materials in the _extras/ folder was instructors/ and I had accidentally copied the files to the learners/ folder instead of moving them from the instructors/ folder.

When building the lesson site, {sandpaper} flattens the folder structure, which unfortunately means that files with identical names are overwritten according to the build order alphabetically by folder ([root], episodes, instructors, learners). It never showed up here because the instructor handouts were identical to the learner handouts at the beginning and then subsequently diverged. No one noticed because the learner handouts always overwrote the instructor handouts.

The mechanism for failure here is that the md5sum table used for cache invalidation of built markdown files had a record of the markdown files for both learners and instructors, but because the learner handout removal clobbered the instructor handouts at the end of the build phase, {sandpaper} was unable to find those files afterwards.

I am sorry about the mixup and will address this in {sandpaper} soon.

Note: the other solution to this is to re-run the lesson build and reset the cached markdown files, but this PR is much preferred.

[github-actions]

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

• 🎯 correct output
• 🖼️ correct figures
• ❓ new warnings
• ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-socialsci/compare/md-outputs..md-outputs-PR-469

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 4 ----
 1 file changed, 4 deletions(-)

What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-11 14:17:17 +0000

[zkamvar]

Another ping on this

[zkamvar]

Another reminder for this. The scheduled builds will continue to fail until this is merged: https://github.com/datacarpentry/r-socialsci/actions/runs/5651197828

[juanfung]

@zkamvar sorry for the delay and thank you!