Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output help on install #621

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Don't output help on install #621

merged 1 commit into from
Jun 15, 2024

Conversation

z0rc
Copy link
Contributor

@z0rc z0rc commented May 27, 2024

This isn't a real test, and it produces noise on each install, which isn't desired in case of running under CI environment.

Fixes #605.

This isn't a real test, and it produces noise on each install, which
isn't desired in case of running under CI environment.
@yxxhero
Copy link
Collaborator

yxxhero commented Jun 15, 2024

@z0rc how do we make sure that helm-diff can work well? maybe we can use > /dev/null to drop the output of diff -h?

@z0rc
Copy link
Contributor Author

z0rc commented Jun 15, 2024

@yxxhero by testing it during development/release process. I don't think testing after install is helpful for end user. Also I didn't found any other plugin that does this kind of testing nowadays. There is https://github.com/technosophos/helm-template from which install-binary.sh was copied, but it's unmaintained.

@yxxhero
Copy link
Collaborator

yxxhero commented Jun 15, 2024

ok. make sense.

@yxxhero yxxhero merged commit e5e3ad5 into databus23:master Jun 15, 2024
17 checks passed
@yxxhero
Copy link
Collaborator

yxxhero commented Jun 15, 2024

@z0rc have a try.

@z0rc
Copy link
Contributor Author

z0rc commented Jun 16, 2024

Works as expected. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't output help on helm plugin install
2 participants