-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HELM_DIFF_IGNORE_UNKNOWN_FLAGS ignored issue #538
fix: HELM_DIFF_IGNORE_UNKNOWN_FLAGS ignored issue #538
Conversation
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
cmdFlags := cmd.Flags() | ||
|
||
// see: https://github.com/databus23/helm-diff/issues/537 | ||
cmdFlags.ParseErrorsWhitelist.UnknownFlags = unknownFlags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, good catch! Thanks.
So does this basically mean DisableFlagParsing: true,
results in `UnknownFlags NOT set by cobra? (Just confirming for learning purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will disrupt a lot of functionality. I think we only support -- dry run=something. @mumoshu WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yxxhero Thanks! Re dry-run, it won't be a good idea to start dropping the backward-compatibility without any prenotices. We are still in the same major ver of helm-diff (3.x). Dropping the compatibility may break downstream user CI/CD pipelines and/or tools.
I think this justifies having more test coverage in future though 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mumoshu yeah. make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yxxhero Awesome work! Going to merge this and cut a new release asap.
@mumoshu there are some other issue should be fixed. do you have any good iede for fixing issue that caused by DisableFlagParsing: true? |
fix: #537