Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove debug msg in normal mode #519

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix: remove debug msg in normal mode #519

merged 1 commit into from
Jan 13, 2024

Conversation

yxxhero
Copy link
Collaborator

@yxxhero yxxhero commented Jan 13, 2024 

+args after legacy dry-run parsing: [--allow-unreleased manifests /tmp/chartify3644874502/helmfile-tests/manifests --reset-values]
 ********************
 
 	Release was not present in Helm.  Diff will show entire contents as new.
FAIL: "helmfile diff" should be consistent

/cc @mumoshu

mumoshu
mumoshu approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it 👍

@yxxhero yxxhero mentioned this pull request Jan 13, 2024
Merged
@yxxhero
Copy link
Collaborator Author

yxxhero commented Jan 13, 2024

@mumoshu should we release 3.9.1? WDYT?

@yxxhero
Copy link
Collaborator Author

yxxhero commented Jan 13, 2024

@mumoshu all passed.

@mumoshu mumoshu merged commit ba3c23d into databus23:master Jan 13, 2024
10 checks passed
@yxxhero yxxhero deleted the remove-debug-msg-in-normal-mode branch January 13, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxxhero @mumoshu