Bump golang, dependencies, replace golint with staticcheck #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoinedeschenes
commented
Dec 15, 2023
•
antoinedeschenes
commented
- Bump golang to 1.20 (syncing with helm)
- Bump helm dependency to 3.13
- Bump k8s libraries to 0.28.4 (syncing with helm)
- Replace deprecated golint linter with staticcheck
- Fix deprecations
yxxhero
approved these changes
Dec 17, 2023
|
LGTM |
|
@mumoshu WDYT? |
mumoshu
reviewed
Dec 18, 2023
mumoshu
reviewed
Dec 18, 2023
mumoshu
reviewed
Dec 18, 2023
mumoshu
reviewed
Dec 18, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/databus23/helm-diff/v3 | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
mumoshu
reviewed
Dec 18, 2023
mumoshu
reviewed
Dec 18, 2023
antoinedeschenes
force-pushed
the
bump-golang-dependencies
branch
3 times, most recently
from
61ce93d
to
ced5bf1
Compare
| @@ -1,6 +1,6 @@ | |||
| module github.com/databus23/helm-diff/v3 | |||
|
|
|||
| go 1.21 | |||
| go 1.20 | |||
There was a problem hiding this comment.
That one is a downgrade, syncing go version to helm.
mumoshu
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM! Approved to trigger the CI build. Let's merge once it passes.
Thank you very much for your contribution @antoinedeschenes (and review @yxxhero)
antoinedeschenes
force-pushed
the
bump-golang-dependencies
branch
from
ced5bf1
to
11e6fcd
Compare
yxxhero
approved these changes
Dec 19, 2023
|
@mumoshu all is pass. |
|
Yup the |
mumoshu
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.