Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove circleci #500

Merged
merged 1 commit into from
Oct 12, 2023
Merged

remove circleci #500

merged 1 commit into from
Oct 12, 2023

Conversation

yxxhero
Copy link
Collaborator

@yxxhero yxxhero commented Oct 11, 2023

Signed-off-by: yxxhero [email protected]

Signed-off-by: yxxhero <[email protected]>
@yxxhero
Copy link
Collaborator Author

yxxhero commented Oct 11, 2023

@mumoshu @databus23 please remove circleCI.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yxxhero LGTM. Thanks a lot for your contribution!

FYI @databus23 and anyone interested, we already run the same set of tests: (

- name: Run unit tests
run: make test
- name: Verify installation
run: |
mkdir -p helmhome
make install HELM_HOME=helmhome
helmhome/plugins/helm-diff/bin/diff version
and more on GitHub Actions so we should just be able to stop CircleCI builds!

@mumoshu mumoshu merged commit 76ed570 into databus23:master Oct 12, 2023
10 of 11 checks passed
@yxxhero yxxhero deleted the remove-circleCI branch October 12, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants