feat: Allow suppressing annotations and labels #468
Conversation
antoinedeschenes
force-pushed
the
feat-suppress-annotations-labels
branch
2 times, most recently
from
e03fd59
to
9722a15
Compare
Signed-off-by: Antoine Deschênes <[email protected]>
antoinedeschenes
force-pushed
the
feat-suppress-annotations-labels
branch
from
9722a15
to
1923e2b
Compare
| @@ -101,6 +105,10 @@ func contentSearch(report *Report, possiblyRemoved []string, oldIndex map[string | |||
| redactSecrets(oldContent, newContent) | |||
| } | |||
|
|
|||
| if len(options.SuppressedAnnotations) > 0 || len(options.SuppressedLabels) > 0 { | |||
| suppressAnnotationsAndLabels(oldContent, newContent, options) | |||
There was a problem hiding this comment.
Presuming all diffMappingResults calls need to be preceded by the new function calls, can we instead put this code inside diffMappingResults for maintainability, changing the third parameter of it to the options instead of a bool? 🐱
There was a problem hiding this comment.
Sorry for the late answer, I have running code also handling nested labels/annotations in pod templates, but I think it quickly gets too specialized, having to handle all cases one by one (CronJob, Job, Deployment, StatefulSet, etc.)
I think having a render script hook before diff could make sense, that would make it possible to run a custom script deleting/sanitizing required fields.
I know there are post-renderer flags passed to helm, but these are only applied to the target helm template command.
WDYT?
|
@antoinedeschenes any updates? |
Allows suppressing annotations and labels in the diff output.
Fixes #390.
Useful to ignore changes that might not make an helm upgrade worthwhile, such as chart version labels.
Also allows hiding labels containing sensitive information, such as
kubectl.kubernetes.io/last-applied-configurationon secrets when using three-way-merge.It currently doesn't handle pod templates in deployments, etc. which could still be very useful (to hide checksum annotation changes, for example).