fix issues in --reset-values and --reuse-values on helm v3 (#160)

Correction of #159
databus23 · Oct 28, 2019 · 99e1351 · 99e1351
1 parent 8c96244
commit 99e1351
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cmd/helm3.go b/cmd/helm3.go
@@ -65,7 +65,7 @@ func (d *diffCmd) template() ([]byte, error) {
 	// Helm automatically enable --reuse-values when there's no --set, --set-string, --set-values, --set-file present.
 	// Let's simulate that in helm-diff.
 	// See https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e
-	shouldDefaultReusingValues := len(d.values) > 0 && len(d.stringValues) > 0 && len(d.valueFiles) > 0 && len(d.fileValues) > 0
+	shouldDefaultReusingValues := len(d.values) == 0 && len(d.stringValues) == 0 && len(d.valueFiles) == 0 && len(d.fileValues) == 0
 	if (d.reuseValues || shouldDefaultReusingValues) && !d.resetValues {
 		tmpfile, err := ioutil.TempFile("", "existing-values")
 		if err != nil {