Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disposition field in SQL backend #3455

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

micheledaddetta-databricks

Description

This feature aims to the chance of running SQL statement for assessment results export in case of large workspaces with a large amount of findings.
Introducing the query_statement_disposition value during the UCX installation can allow users to select the proper disposition method to use when running large queries. This parameter is added in the config.yml file and used for the SqlBackend definition. Using this approach, large queries will not fail.

Changes

Added SQL query statement disposition choice during the UCX installation
Added query_statement_disposition value in the config file

Linked issues

Resolves #3447

Functionality

  • modified existing commands: databricks labs install ucx, databricks labs ucx export-assessment

Tests

  • manually tested

Having this feature will allow the execution of queries with not negligible dimension results.
Using this field during the configuration, will allow to export assessment results for larger workspaces.
@micheledaddetta-databricks micheledaddetta-databricks requested a review from a team as a code owner December 19, 2024 10:12
@micheledaddetta-databricks
Copy link
Author

Hello @gueniai @JCZuurmond, as required, I created the new pull request related to SQL disposition using the verified commits.

@gueniai gueniai requested a review from JCZuurmond December 19, 2024 14:18
@JCZuurmond
Copy link
Member

From the other PR: #3448

Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JCZuurmond
Copy link
Member

CI does not work for external contributors, running the integration tests in: https://github.com/databrickslabs/ucx/actions/runs/12414662722. @gueniai , if those pass, the PR can be merged

@JCZuurmond
Copy link
Member

CI passed except test_table_migration_convert_manged_to_external which is unrelated and solved in #3459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add Disposition parameter in SqlBackend creation
3 participants