Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ucx dashboards from Lakeview dashboard crawler #3450

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Dec 16, 2024

Changes

Exclude ucx dashboards from Lakeview dashboard crawler as this would be a false positive dashboard

Linked issues

Resolves #3441

Functionality

  • modified existing workflow: assessment

Tests

  • manually tested
  • added unit tests
  • verified on staging environment (screenshot attached)

@JCZuurmond JCZuurmond self-assigned this Dec 16, 2024
@JCZuurmond JCZuurmond requested a review from a team as a code owner December 16, 2024 15:46
@JCZuurmond
Copy link
Member Author

UCX Lakeview dashboards are not included anymore:

Screenshot 2024-12-16 at 16 43 53
Screenshot 2024-12-16 at 16 44 41

@JCZuurmond JCZuurmond added the step/assessment go/uc/upgrade - Assessment Step label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

✅ 29/29 passed, 1 flaky, 3 skipped, 28m0s total

Flaky tests:

  • 🤪 test_running_real_assessment_job (5m2.108s)

Running from acceptance #7823

@gueniai gueniai requested a review from HariGS-DB December 18, 2024 14:29
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step/assessment go/uc/upgrade - Assessment Step
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

[TECH DEBT]: Exclude the UCX dashboards from the LakeviewDashboardCrawler
2 participants