-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli command to create directfs to table mapping #3427
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction looks good. Just thinking again about the idea of merging this with the table_mapping instead of a separate mapping. Did we log our decision about this somewhere?
raise ValueError(msg) | ||
if not directfs_snapshot: | ||
msg = "No directfs references found in code" | ||
raise ValueError(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not find any directfs references then we just raise the error and return
for table in tables_snapshot: | ||
for directfs_record in directfs_snapshot: | ||
if table.location: | ||
if directfs_record.path in table.location: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about dfsa's that do not have a match with tables? We want to include those too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wont be having a mapping with a table to replace them and ignore them right?
Table mapping is used entirely for table migration, while this is for code migration. I think we should keep this separate. But no we have not logged the decision anywhere. |
|
Changes
The directfs access in the code that can be replaced by table would need a mapping to be reviewed/updated by the user. Introduces a cli command that creates the mapping file from the directfs usages.
Linked issues
Introduces #392
Functionality
Tests