Store code migration progress in multiworkspace history log and visualize in dashboard #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
the
feat/migration-progress
This was referenced Nov 12, 2024
JCZuurmond
commented
Nov 13, 2024
| ] | ||
| return records | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def catalog_populated( # pylint: disable=too-many-arguments |
There was a problem hiding this comment.
Expand name to be more explicit about that it is populated with the data fixture above, e.g. rename to make_catalog_with_test_data(catalog_name: str)
There was a problem hiding this comment.
If a fixture is longer than 10 lines, it should be make_
| runtime_ctx.direct_filesystem_access_progress.append_inventory_snapshot(dfsas) | ||
| del runtime_ctx.direct_filesystem_access_progress | ||
| runtime_ctx.used_table_progress.append_inventory_snapshot(used_tables) | ||
| del runtime_ctx.used_table_progress | ||
| return runtime_ctx.ucx_catalog | ||
|
|
||
|
|
There was a problem hiding this comment.
Rename dashboard_metadata to make_dummy_dashboard (or something alike)
JCZuurmond
added a commit
that referenced
this pull request
Nov 15, 2024
This was referenced Nov 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
## Changes Follow the more common pattern of expect objects in a class signature. Those objects are passed on from the context. Makes testing more straightforward Breaking down the linked PR below. ### Linked issues Progresses #3045 Breaks up #3112 ### Tests - [x] modified unit tests - [x] modified integration tests
JCZuurmond
added a commit
that referenced
this pull request
Dec 17, 2024
JCZuurmond
added a commit
that referenced
this pull request
Dec 17, 2024
JCZuurmond
added a commit
that referenced
this pull request
Dec 20, 2024
JCZuurmond
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Store code migration progress in multiworkspace history log and visualize in dashboard
Linked issues
Resolves #3045
Functionality
migration-processTests