Implement migration sequencing (phase 2) #3009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
ericvergnaud
commented
Oct 17, 2024
| def register_workflow_job(self, job: jobs.Job) -> MigrationNode: | ||
| job_node = self._nodes.get(("JOB", str(job.job_id)), None) | ||
| job_node = self._nodes.get(("WORKFLOW", str(job.job_id)), None) |
There was a problem hiding this comment.
align with ObjectInfo type enum
|
❌ 73/77 passed, 4 failed, 4 skipped, 1h49m41s total ❌ test_migration_sequencing_job_with_task_referencing_non_existing_cluster: TypeError: MigrationSequencer.__init__() missing 1 required positional argument: 'administrator_locator' (224ms)❌ test_migration_sequencing_job_with_task_referencing_cluster: TypeError: MigrationSequencer.__init__() missing 1 required positional argument: 'administrator_locator' (2.028s)❌ test_running_real_assessment_job_ext_hms: databricks.sdk.errors.platform.InternalError: Failed to list databases due to Py4JSecurityException. Update or reinstall UCX to resolve this issue. (22m1.346s)❌ test_migration_sequencing_simple_job: TypeError: MigrationSequencer.__init__() missing 1 required positional argument: 'administrator_locator' (2.627s)Running from acceptance #7539 |
ericvergnaud
changed the title
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
2 tasks
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
nfx
requested changes
Oct 31, 2024
| ws_path = WorkspacePath(self._ws, object_id) | ||
| object_owner = WorkspacePathOwnership(self._admin_locator, self._ws).owner_of(ws_path) | ||
| else: | ||
| raise ValueError(f"{object_type} not supported yet!") |
There was a problem hiding this comment.
where this exception is caught? it'll crash the assessment workflow if unhandled.
| @@ -78,8 +78,8 @@ def as_message(self) -> str: | |||
|
|
|||
|
|
|||
| class WorkflowTask(Dependency): | |||
| def __init__(self, ws: WorkspaceClient, task: jobs.Task, job: jobs.Job): | |||
| loader = WrappingLoader(WorkflowTaskContainer(ws, task, job)) | |||
| def __init__(self, ws: WorkspaceClient, task: jobs.Task, job: jobs.Job, cache: WorkspaceCache | None = None): | |||
There was a problem hiding this comment.
don't add | None as constructor dependencies - it leads to non-deterministic logic and subtle bugs that are harder to diagnose later.
JCZuurmond
force-pushed
the
migration-sequencing-phase-1
branch
from
f39bf38 to
ba8b4c6
Compare
JCZuurmond
force-pushed
the
migration-sequencing-phase-2
branch
from
3c34640 to
eb79746
Compare
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implement migration steps for notebooks and python files
Linked issues
Progresses #1415
Functionality
None
Tests