[PLAT-111995] detect and prevent polluted data return to user #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
force-pushed
the
PLAT-111995-ooo
branch
2 times, most recently
from
36f5292 to
c336a1e
Compare
yuchen-db
approved these changes
Jul 5, 2024
jnyi
changed the title
Signed-off-by: Yi Jin <[email protected]>
hczhu-db
reviewed
Jul 17, 2024
Comment on lines
+19
to
+21
| if v == "" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This branch means the time series doesn't have this label, but the matches (filters) have. The workflow should go to do a match against the default empty string. Otherwise, it would cause the following false negative.
lbls = {"a": "b"}
matches = [ {Name: "b", Type: LabelMatcher_EQ, Value: "x" }]
There was a problem hiding this comment.
emm, i think i added this due to a unit test failure, let me figure out what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will invalidate Series request if the returned results doesn't match what it actually wants. Also we will dedup based on smaller values.
Changes
Verification