receive perf #110
Open
receive perf #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
reviewed
Dec 4, 2024
pkg/receive/handler.go
Outdated
Comment on lines
792
to
798
| var localWrites, remoteWrites map[endpointReplica]map[string]trackedSeries | ||
| var err error | ||
| if h.receiverMode == IngestorOnly { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicas(params.tenant, params.replicas, params.writeRequest.Timeseries) | ||
| } else { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicas(params.tenant, params.replicas, params.writeRequest.Timeseries) | ||
| } |
There was a problem hiding this comment.
didn't see difference for the two if-branch?
jnyi
reviewed
Dec 4, 2024
| } | ||
|
|
||
| func (h *Handler) distributeTimeseriesToReplicasIngestorOnly(tenantHTTP string, replicas []uint64, timeseries []prompb.TimeSeries) (map[endpointReplica]map[string]trackedSeries, map[endpointReplica]map[string]trackedSeries, error) { | ||
| remoteWrites := make(map[endpointReplica]map[string]trackedSeries) |
There was a problem hiding this comment.
actually should avoid allocation if remote writes are empty, you can consider to reuse a static map for ingestor
jnyi
reviewed
Dec 4, 2024
yuchen-db
force-pushed
the
yuchen-db/writer-perf
branch
from
201767f to
cf49e95
Compare
|
Nice work. Have you deployed the change to a dev cluster? Any CPU usage decrease? |
hczhu-db
requested changes
Dec 4, 2024
Comment on lines
+794
to
+798
| if h.receiverMode == IngestorOnly { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicasIngestorOnly(params.tenant, params.replicas, params.writeRequest.Timeseries) | ||
| } else { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicas(params.tenant, params.replicas, params.writeRequest.Timeseries) | ||
| } |
There was a problem hiding this comment.
Can you add code comment to explain the difference?
| } | ||
| localWrites[endpointReplica] = map[string]trackedSeries{tenantHTTP: {seriesIDs: seriesids, timeSeries: timeseries}} | ||
| } | ||
| fmt.Println("localWrites (IngestorOnly):") |
There was a problem hiding this comment.
Are those fmt.Print*() only for your debugging? Remove them?
| if h.receiverMode == IngestorOnly { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicasIngestorOnly(params.tenant, params.replicas, params.writeRequest.Timeseries) | ||
| } else { | ||
| localWrites, remoteWrites, err = h.distributeTimeseriesToReplicas(params.tenant, params.replicas, params.writeRequest.Timeseries) |
There was a problem hiding this comment.
distributeTimeseriesToReplicas() can be optimized further by removing localWrites related logic. I'd suggest creating a new function, distributeTimeseriesToReplicasRouterOnly().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification