Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Generic Resource Wrapper #4172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Oct 30, 2024

Changes

WIP implementation of a generic, reusable resource wrapper. This allows us to enforce consistent behavior across all resources without requiring different interfaces than exposed by the plugin framework.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from a team as code owners October 30, 2024 10:28
@mgyucht mgyucht requested review from hectorcast-db and removed request for a team October 30, 2024 10:28
@mgyucht mgyucht temporarily deployed to test-trigger-is October 30, 2024 10:29 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the generic-resource-wrapper branch from 4cc5236 to 6f73013 Compare November 3, 2024 17:11
@rauchy rauchy temporarily deployed to test-trigger-is November 3, 2024 17:12 — with GitHub Actions Inactive
Copy link

github-actions bot commented Nov 3, 2024

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4172
  • Commit SHA: 6f73013f43e5672380bc38d2862c875e834db034

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is November 3, 2024 17:12 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11653206360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants