-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add datasource databricks_users
#4028
base: main
Are you sure you want to change the base?
Conversation
databricks_users
databricks_users
Did the changes and tests succeded. Appreciate the guidance, @alexott. |
252f9cf
to
7e4b3d9
Compare
…chema, and only request the id, userName, and displayName attributes. added succesful initial test_case on data_users_test.go
…o to allow filtering by userName, and added additional test cases on data_users_test.go
…tests, and added the resource definition into the provider
…pport for workspace-level and account-level provider.
7e4b3d9
to
7fa5823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Good first cut. We'll need to make some changes before merging.
internal/providers/pluginfw/resources/user/data_users_acc_test.go
Outdated
Show resolved
Hide resolved
internal/providers/pluginfw/resources/user/data_users_acc_test.go
Outdated
Show resolved
Hide resolved
…REST API's flexibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but please consider my comments about additional attributes - this will decrease the load on SCIM backend
@alexott implemented the changes you requested. Appreciate the insights. Please give it a look and let me know how we want to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good, small comments
@alexott I've implemented the last batch of requested changes. LMK how it looks. |
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Test Details: go/deco-tests/12054551572 |
Changes
Added
databricks_users
data source as requested in #3468 to retrieve multiple users from both the account and workspace-level APIs with optional filtering bydisplay_name_contains
oruser_name_contains
, enabling bulk user management operations.Closes #3468
Tests
make test
run locallydocs/
folderinternal/acceptance