Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add datasource databricks_users #4028

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

dgomez04
Copy link
Contributor

@dgomez04 dgomez04 commented Sep 17, 2024

Changes

Added databricks_users data source as requested in #3468 to retrieve multiple users from both the account and workspace-level APIs with optional filtering by display_name_contains or user_name_contains, enabling bulk user management operations.

Closes #3468

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@dgomez04 dgomez04 requested review from a team as code owners September 17, 2024 23:02
@dgomez04 dgomez04 requested review from mgyucht and removed request for a team September 17, 2024 23:02
@alexott
Copy link
Contributor

alexott commented Oct 2, 2024

@dgomez04 to fix integration test - make this change: f38cdbc

@alexott alexott changed the title Add datasource databricks_users [Feature] Add datasource databricks_users Oct 2, 2024
@dgomez04
Copy link
Contributor Author

dgomez04 commented Oct 2, 2024

Did the changes and tests succeded. Appreciate the guidance, @alexott.

@dgomez04 dgomez04 force-pushed the feature/3468-databricks_users branch from 252f9cf to 7e4b3d9 Compare October 23, 2024 18:19
@dgomez04 dgomez04 force-pushed the feature/3468-databricks_users branch from 7e4b3d9 to 7fa5823 Compare October 23, 2024 18:28
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Good first cut. We'll need to make some changes before merging.

docs/data-sources/users.md Outdated Show resolved Hide resolved
internal/acceptance/data_users_test.go Outdated Show resolved Hide resolved
internal/acceptance/data_users_test.go Outdated Show resolved Hide resolved
internal/acceptance/data_users_test.go Outdated Show resolved Hide resolved
internal/acceptance/data_users_test.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
@dgomez04 dgomez04 requested a review from mgyucht November 1, 2024 18:40
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please consider my comments about additional attributes - this will decrease the load on SCIM backend

docs/data-sources/users.md Show resolved Hide resolved
docs/data-sources/users.md Show resolved Hide resolved
docs/data-sources/users.md Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
docs/data-sources/users.md Show resolved Hide resolved
@dgomez04
Copy link
Contributor Author

@alexott implemented the changes you requested. Appreciate the insights. Please give it a look and let me know how we want to proceed.

@dgomez04 dgomez04 requested a review from alexott November 25, 2024 16:55
@databricks databricks deleted a comment from github-actions bot Nov 26, 2024
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, small comments

docs/data-sources/users.md Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/user/data_users.go Outdated Show resolved Hide resolved
@dgomez04 dgomez04 requested a review from alexott November 27, 2024 16:18
@dgomez04
Copy link
Contributor Author

@alexott I've implemented the last batch of requested changes. LMK how it looks.

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4028
  • Commit SHA: 99d7d2cec3b9130c86c03398619a04885c89c3ef

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12054551572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] New data block databricks_users
4 participants