Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Added "databricks_groups" data resource to list all the groups in the databricks account. #3992

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Feature] Added "databricks_groups" data resource to list all the groups in the databricks account. #3992

wants to merge 5 commits into from

Conversation

sergiumpopa
Copy link
Contributor

@sergiumpopa sergiumpopa commented Sep 4, 2024 •
edited
Loading

Changes

Added a databricks_groups data resource to list all groups in the account - it addresses #3432.
The resource returns only the display_name field from the groups, which can then be used with the databricks_group data resource to retrieve more information.

It accepts filter as an argument, with the same functionality as the API parameter.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@sergiumpopa sergiumpopa marked this pull request as ready for review September 4, 2024 11:57
@sergiumpopa sergiumpopa requested review from a team as code owners September 4, 2024 11:57
@sergiumpopa sergiumpopa requested review from mgyucht and removed request for a team September 4, 2024 11:57
@sergiumpopa sergiumpopa changed the title [FEATURE] Added "databricks_groups" data resource to list all the groups in the databricks account. [Feature] Added "databricks_groups" data resource to list all the groups in the databricks account. Sep 4, 2024
alexott
alexott requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to discuss if it should work on account level as well

docs/data-sources/groups.md Outdated Show resolved Hide resolved
docs/data-sources/groups.md Outdated Show resolved Hide resolved
internal/acceptance/data_groups_test.go Show resolved Hide resolved
scim/data_groups.go Outdated Show resolved Hide resolved
scim/data_groups.go Outdated Show resolved Hide resolved
scim/data_groups_test.go Outdated Show resolved Hide resolved
scim/scim.go
@@ -120,7 +120,7 @@ type GroupList struct {
StartIndex int32 `json:"startIndex,omitempty"`
ItemsPerPage int32 `json:"itemsPerPage,omitempty"`
Schemas []URN `json:"schemas,omitempty"`
Resources []Group `json:"resources,omitempty"`
Resources []Group `json:"Resources,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, we need to understand when this has changed...

@sergiumpopa sergiumpopa requested a review from alexott September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

@alexott alexott Awaiting requested review from alexott

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiumpopa @alexott @sergiu-databricks