Make reflect_resource and customizable_schema work for data source #3880
+650
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfeng-db
commented
Aug 9, 2024
mgyucht
reviewed
Aug 15, 2024
| "github.com/hashicorp/terraform-plugin-framework/resource/schema" | ||
| "github.com/hashicorp/terraform-plugin-framework/schema/validator" | ||
| ) | ||
|
|
There was a problem hiding this comment.
type Validator interface {
Whatever()
}
type ResourceValidator struct{
validator schema.Validator
}
func (ResourceValidator) Whatever() {}
type DataSourceValidator struct {
validator dataschema.Validator
}
AddValidators(Validator) Attribute| field.Set(newSlice) | ||
|
|
||
| return val.Interface().(schema.Attribute) | ||
| cb := func(attr Attribute) Attribute { |
There was a problem hiding this comment.
Idea: expose type-specific methods here instead of any?
| return a | ||
| } | ||
|
|
||
| type MapAttribute struct { |
There was a problem hiding this comment.
For this type and the ones below, doccomments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
## Changes <!-- Summary of your changes that are easy to understand --> - Addressing comments from #3880 - Adding AttributeBuilder - the common interface for building data source schema and resource schema - Adding customisation functions for each type of attribute ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] `make test` run locally - [x] relevant change in `docs/` folder - [x] covered with integration tests in `internal/acceptance` - [x] relevant acceptance tests are passing - [x] using Go SDK
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
## Changes <!-- Summary of your changes that are easy to understand --> - Addressed comments in #3880 - Add CustomizableSchema for PluginFramework ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] `make test` run locally - [x] relevant change in `docs/` folder - [x] covered with integration tests in `internal/acceptance` - [x] relevant acceptance tests are passing - [x] using Go SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptance