Add docs for permission in 03 and add enable_trace in 04 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for adding this @chengyineng38 ! Just one small thing about which data we use for review.
rag_app_sample_code/A_POC_app/pdf_uc_volume/03_deploy_poc_to_review_app.py
Outdated
Show resolved
Hide resolved
rag_app_sample_code/A_POC_app/pdf_uc_volume/04_create_evaluation_set.py
Outdated
Show resolved
Hide resolved
prithvikannan
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
LGTM. I'm not an official maintainer of this repo so adding @smurching to approve
|
@chengyineng38 could you share proof of manual testing that this change works (feel free to reach out directly to me with a notebook link etc)? Otherwise looks good, thanks for the updates! |
smurching
reviewed
Aug 21, 2024
|
|
||
| from databricks.agents import enable_trace_reviews | ||
|
|
||
| request_id_list = request_log_df.select(F.col("request_id")).rdd.flatMap(lambda x: x).collect() |
There was a problem hiding this comment.
QQ, why do we need the .rdd.flatMap call? It might be cleaner to e.g. use .toPandas instead, since RDDs and their APIs are deprecated
There was a problem hiding this comment.
Good point. Simplified below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.