Dev Container environment #882
Open
+80
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Malo Jaffré <[email protected]>
ghjklw
requested review from
andrefurlan-db,
benc-db and
rcypher-databricks
as code owners
|
Awesome! This is a cool effort, and will review in the next day or so. |
|
I really need to update the contributing doc, but thank you for taking a pass at it :). |
benc-db
approved these changes
Dec 18, 2024
| "python.languageServer": "Pylance", | ||
| "ruff.fixAll": true, | ||
| "ruff.format.args": [ | ||
| "--config=pyproject.toml" |
There was a problem hiding this comment.
I wouldn't think this is necessary; I would think it would default to local pyproject.toml.
There was a problem hiding this comment.
You're probably right, I will test and remove if unnecessary.
| ``` | ||
| tox -e linter | ||
| ``` | ||
| This project uses [Ruff](https://docs.astral.sh/ruff/) and [mypy](https://www.mypy-lang.org/) for linting and static type checks. |
|
Just add an entry in the Changelog (1.9.2) when you're ready for me to merge this. You might want to give a pointer to how to connect this up in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To facilitate working on this project, I began setting up a Dev Container / GitHub codespace environment.
This is a fairly basic setup at this point, but I believe it might be useful to others, and a good way to lower the threshold to contributing to the adapter.
Potential for improvement:
databricks_demoproject as described inCONTRIBUTING.mdbecause thedbt-databricksadapter doesn't seem to be recognized by dbt when installed in editable mode.Could you please let me know if this is something you're interesting in before I put any more effort in it.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.