[PECO-1436] [sqlalchemy] Include sqlalchemy __version__ in user-agent #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 25, 2024 19:37
to reuse code where available Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
benc-db
reviewed
Jan 26, 2024
benc-db
approved these changes
Jan 26, 2024
|
I'm double-checking the correct format. Will hold off on merging this until next week. |
Signed-off-by: Jesse Whitehouse <[email protected]>
format function outside of its existing declaration so I can unit test it Signed-off-by: Jesse Whitehouse <[email protected]>
in query history. Need to investigate this before merging. Signed-off-by: Jesse Whitehouse <[email protected]>
kravets-levko
requested review from
rcypher-databricks,
jackyhu-db and
kravets-levko
as code owners
Signed-off-by: Levko Kravets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr updates our user-agent setting logic for the sqlalchemy dialect so that we include the sqlalchemy package version.
I used this as an opportunity to reorganise the two (now three) user agent tests into their own test class.
Here's an example of how it's recorded in the query history: