Clear env vars when running 'make test' #2039
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are sensible to DATABRICKS_HOST and DATABRICKS_TOKEN and fail if they are set.
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Dec 20, 2024
| @@ -12,7 +12,7 @@ test: lint testonly | |||
|
|
|||
| testonly: | |||
| @echo "✓ Running tests ..." | |||
| @gotestsum --format pkgname-and-test-fails --no-summary=skipped --raw-command go test -v -json -short -coverprofile=coverage.txt ./... | |||
| @DATABRICKS_HOST= DATABRICKS_TOKEN= gotestsum --format pkgname-and-test-fails --no-summary=skipped --raw-command go test -v -json -short -coverprofile=coverage.txt ./... | |||
There was a problem hiding this comment.
Please include DATABRICKS_CONFIG_PROFILE as well. Pretty common.
Alternatively, this could be a shell script wrapper, e.g. scripts/cleanenv, that unsets them in a single spot.
There was a problem hiding this comment.
+1 to separate shell script wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are sensible to DATABRICKS_HOST and DATABRICKS_TOKEN and fail if they are set.