Postpone mkdir until start of upload #1956
Open
+70
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
force-pushed
the
DECO-23879--do-not-create-path
branch
from
22c7110 to
bbd42c0
Compare
denik
changed the title
denik
changed the title
andrewnester
approved these changes
Dec 5, 2024
pietern
reviewed
Dec 5, 2024
| return err | ||
| } | ||
| return false, nil | ||
|
|
There was a problem hiding this comment.
Can we still test if we have permission to write to a parent that does exist?
We run this during validation, so if we cannot write to the destination path, it's good to surface early.
denik
force-pushed
the
DECO-23879--do-not-create-path
branch
from
bbd42c0 to
8c90966
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This ensure that "bundle validate" does not create remote directory. Extend empty_bundle_test.go to check if remote path is created prematurely
denik
force-pushed
the
DECO-23879--do-not-create-path
branch
from
8c90966 to
48048dd
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12279631939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move MkdirsByPath call outside of sync.New because sync.New is also used by "bundle validate" which is supposed to be side-effect-free.
Instead, remember if the path existed or not and then create it in RunOnce().
Tests
Extended TestAccEmptyBundleDeploy to also do "bundle validate" and to check that the path does appear but after deploy and not after validate.