Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundle): cluster permissions from root bundle permissions #1859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mike-F-G
Copy link

@Mike-F-G Mike-F-G commented Oct 25, 2024

Issue

Defining permissions at the root of the bundle with the recently added clusters as resources for all purpose clusters are not aligned with expected permissions.

Changes

Add permission conversion for the Databricks Clusters resources according to the cluster ACLs

Tests

Tests aligned with the expected definition

@Mike-F-G Mike-F-G force-pushed the fix/cluster_permissions branch from ab57b6c to faa7963 Compare October 25, 2024 14:06
@andrewnester
Copy link
Contributor

andrewnester commented Oct 29, 2024

@Mike-F-G thanks for the PR! Just to clarify: you had issues when you defined top level bundle permissions but they were not working for clusters, is it correct? Because your PR adds support top level permissions but not really fixes the ones defined inside cluster config itself.

Cluster permissions were fixed in this PR #1826 which was released last week in 0.231.0 version

@Mike-F-G Mike-F-G force-pushed the fix/cluster_permissions branch from faa7963 to 6057cdc Compare October 29, 2024 13:47
@Mike-F-G
Copy link
Author

@Mike-F-G thanks for the PR! Just to clarify: you had issues when you defined top level bundle permissions but they were not working for clusters, is it correct? Because your PR adds support top level permissions but not really fixes the ones defined inside cluster config itself.

Cluster permissions were fixed in this PR #1826 which was released last week in 0.231.0 version

Thank you for taking the time to consider this PR. Yes you are totally right, I was mistaken on the scope of the PR & the tests related to my change.

My initial issue is indeed fixed with #1826. Therefore let met switch this PR to take into account the bundle level of permissions for the clusters. Aligning the initial modification with its usage.

@Mike-F-G Mike-F-G changed the title fix(bundle): cluster permissions feat(bundle): cluster permissions from root bundle permissions Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants