Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary GET call in pipeline runner #1850

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Oct 21, 2024

Changes

This GET API call is unnecessary and serves no purpose. Let's remove it. Noticed this when I was adding a unit test for the pipeline runner here: #1849

Tests

Manually.

Case 1: The pipeline does not exist

Before:

➜  my_project git:(master) ✗ databricks bundle run my_project_pipeline -p dogfood
Error: User [email protected] does not have View permissions on pipeline 9941901a-e48b-4d04-b6ba-e0072ad126bg.

After:

➜  my_project git:(master) ✗ cli bundle run my_project_pipeline -p dogfood
Error: User [email protected] does not have Run permissions on pipeline 9941901a-e48b-4d04-b6ba-e0072ad126bg.

Case 2: Pipeline exists

Before:

➜  my_project git:(master) ✗ databricks bundle run my_project_pipeline -p dogfood --restart
Update URL: https://e2-dogfood.staging.cloud.databricks.com/#joblist/pipelines/9941901a-e48b-4d04-b6ba-e0072ad126bf/updates/0f988d62-9ec7-49f1-b429-5572ece3a9aa

2024-11-18T15:30:36.054Z update_progress INFO "Update 0f988d is WAITING_FOR_RESOURCES."

After:

➜  my_project git:(master) ✗ cli bundle run my_project_pipeline -p dogfood --restart
Update URL: https://e2-dogfood.staging.cloud.databricks.com/#joblist/pipelines/9941901a-e48b-4d04-b6ba-e0072ad126bf/updates/87b43350-6186-4a9b-9d0e-38da2ecf33ae

2024-11-18T15:28:27.144Z update_progress INFO "Update 87b433 is WAITING_FOR_RESOURCES."

@pietern
Copy link
Contributor

pietern commented Nov 18, 2024

@shreyas-goenka Do you want to proceed with this?

@shreyas-goenka shreyas-goenka changed the title Remove unnecessary API call in pipeline runner Remove unnecessary GET call in pipeline runner Nov 18, 2024
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1850
  • Commit SHA: 50af744a974f7ba3bc6ad1dbb406a4c007862628

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11895733199

@shreyas-goenka shreyas-goenka marked this pull request as ready for review November 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants